Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for player overhead names not disapearing. #228

Merged
merged 2 commits into from
Aug 29, 2020
Merged

Fix for player overhead names not disapearing. #228

merged 2 commits into from
Aug 29, 2020

Conversation

Explooosion-code
Copy link
Contributor

For some reason in the code there was a for loop to iterate over players and not over the created gamertags dict. This resulted in mp gamer tags not disaprearing when checkbox unchecked.

For some reason in the code there was a for loop to iterate over players and not over the created gamertags dict. This resulted in mp gamer tags not disaprearing when checkbox unchecked.
@TomGrobbe
Copy link
Owner

@Explooosion-code The reason is very simple. This native was undocumented when it was implemented and the player tag ids were always between 1 and 255 back then. This has probably changed since onesync (infinity)

@Explooosion-code
Copy link
Contributor Author

Ok, that makes sense 🤷 | I tested this on onesync infinity off and on and worked on both. Hope this is helpful 😀

@TomGrobbe TomGrobbe merged commit 09dc09d into TomGrobbe:master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants